Made folder search case insensitive #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @morshedalam , thanks for the PR. I need to verify that this is desired functionality since I didn't see anything at first from the docs. It makes sense since most filesystems work like this, but I'll just double-check to be sure. After that, we might add a new test as well as bump the patch version since this fixes a bug. Thanks again! |
|
Heya, not sure why I made a new PR, but this issue was resolved here: 15f583f |
|
@xhocquet Because, it wasn't fixed when I made PR. I made a change on June 19 and you fixed it on Nov 18. Anyway, thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case sensitive folder search does not find folder with different case but throwing exception on creating same folder.