New method: Client#upload_file_from_io #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 🙏 for the PR @moonglum ! At first glance everything looks good, I'll just do a proper review + run my smoke tests when I get some time this weekend. |
|
Awesome, thanks 👍 |
xhocquet
approved these changes
Aug 5, 2019
|
@moonglum Smoke tests look great! If you could make one small change, I'll merge your PR: |
This method allows users to upload a file from IO. This is useful if the file you want to upload is not read from disk, but for example from an HTTP request.
|
@xhocquet Awesome 👍 I bumped the version to 1.11.0 👍 |
|
@moonglum Congrats and thank you for the contribution! Should be out on Rubygems shortly :) |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #82
This method allows users to upload a file from IO. This is useful if the file you want to upload is not
read from disk, but for example from an HTTP request.
To have less code duplication, the existing upload_file method now uses the new upload_file_from_io method internally.