Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package id getter function #222

Merged

Conversation

jmark
Copy link

@jmark jmark commented Jul 18, 2023

In some scenarios it is useful to have a dedicated query function for the package id registered by libsc. For example, not all wrapper
generators or FFIs (foreign function interfaces) support to read global external variables.

@cburstedde
Copy link
Owner

Thanks!

@cburstedde
Copy link
Owner

Do you think you may rebase the change to have non-related commits disappear?

@cburstedde
Copy link
Owner

Do you think you may rebase the change to have non-related commits disappear?

Thanks again! For me to merge could you please simplify the history to a minimum @jmark? BR Carsten

@cburstedde
Copy link
Owner

Thanks for this useful contribution @jmark. It may help us to close #204 together with previous updates.
Would you find it ok to simplify this PR to one commit without the merges in the history?

@jmark jmark force-pushed the feature-add-package-id-getter-function branch from 0834ad5 to 89a8c86 Compare October 9, 2023 13:58
@jmark
Copy link
Author

jmark commented Oct 9, 2023

@cburstedde I cleaned up the git history. Let me know if there is anything else to do.

@cburstedde
Copy link
Owner

@cburstedde I cleaned up the git history. Let me know if there is anything else to do.

Hi @jmark, thanks again and sorry to hassle you for this useful contribution.

The history as I see it contains some really old merges, such as PR #1 and #27. I'd feel more comfortable if you were to cherry-pick just the one commit with the code changes on the current master and discard the rest of the history.

In addition, if you might add a doc/author_markert.txt file the same way you did it with libsc?

@jmark jmark force-pushed the feature-add-package-id-getter-function branch from 89a8c86 to c785133 Compare October 10, 2023 08:28
@jmark
Copy link
Author

jmark commented Oct 10, 2023

@cburstedde All good and many thanks for your advice!

@cburstedde cburstedde merged commit aee0bf1 into cburstedde:master Oct 10, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants