Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake examples #300

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Cmake examples #300

merged 5 commits into from
Apr 18, 2024

Conversation

mkirilin
Copy link
Collaborator

@mkirilin mkirilin commented Apr 1, 2024

This PR simplifies and unifies examples/CMakeLists.txt file.
In addition, it make examples build by default.

@mkirilin mkirilin requested a review from cburstedde April 1, 2024 14:49
@mkirilin mkirilin self-assigned this Apr 1, 2024
@cburstedde
Copy link
Owner

Thanks! is this as much as possible analogous to the libsc code for the examples?

@mkirilin
Copy link
Collaborator Author

It is a good balance between simplicity and similarity with the libsc, considering the peculiarities of p4est (e.g. 2 or 3 dimensions, etc.)

@cburstedde
Copy link
Owner

cburstedde commented Apr 15, 2024 via email

@mkirilin
Copy link
Collaborator Author

Cool! CMake has its own way of defining enable p4est, p6est, p8est. Do the
examples compile in all combinations?

Yes, I've tried all the 4 combinations of p6est / p8est and it works well.

@cburstedde cburstedde merged commit 7896878 into cburstedde:develop Apr 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants