Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Drop Masonry Layout for image grid #489

Closed
brenoferreira opened this issue Sep 10, 2019 · 3 comments · Fixed by #538
Closed

Drop Masonry Layout for image grid #489

brenoferreira opened this issue Sep 10, 2019 · 3 comments · Fixed by #538
Labels
accessibility (a11y) 💻 aspect: code Concerns the software code in the repository help wanted Open to participation from the community

Comments

@brenoferreira
Copy link
Contributor

brenoferreira commented Sep 10, 2019

Masonry Layout doesn't work on Server Side Rendering due to browser API dependencies. So it's only rendered on the client.

It also doesn't seem to be very accessible, as tabIndex doesn't seem to work, so users who don't use a mouse as input device, but rather a keyboard or some other accessibility device, probably can't browse through the results.

Ideally, the new grid should be rendered using CSS Grid or Flexbox, with no JS dependency on browser document APIs

@brenoferreira
Copy link
Contributor Author

This might work: xieranmaya/blog#6

@brenoferreira brenoferreira added the help wanted Open to participation from the community label Oct 11, 2019
@annatuma annatuma added this to To Be Prioritized in Backlog Nov 14, 2019
@dos077
Copy link
Contributor

dos077 commented Nov 22, 2019

I ported brenoferreira's suggestion to Vue. It works fine. Is this still an issue? I've only made the thumbnails img tags. Will need to rework and probably rename the gridcell components.

Screenshot:
https://drive.google.com/file/d/1D1sEILcG1vPutOYv3XsHOnNbco3Oz_AW/view?usp=sharing

Mobile:
https://drive.google.com/file/d/1se_vLgnQXtLjWcnsnFskGJYrke2BF1Xo/view?usp=sharing

@brenoferreira
Copy link
Contributor Author

Feel free to open a pull request

@kgodey kgodey added this to Ready for Development in Active Sprint via automation Feb 25, 2020
@kgodey kgodey removed this from To Be Prioritized in Backlog Feb 25, 2020
@kgodey kgodey moved this from Ready for Development to Done in Active Sprint Feb 25, 2020
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository and removed tech labels Oct 1, 2020
@TimidRobot TimidRobot removed this from Done in Active Sprint Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility (a11y) 💻 aspect: code Concerns the software code in the repository help wanted Open to participation from the community
Development

Successfully merging a pull request may close this issue.

3 participants