Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Added Grid Documentation Story #802

Merged
merged 3 commits into from Dec 2, 2020
Merged

Added Grid Documentation Story #802

merged 3 commits into from Dec 2, 2020

Conversation

nimishbongale
Copy link
Contributor

Fixes

Fixes #619 by @zackkrida

Description

Adds the Fullhd, Desktop, Tablet, Mobile grid component stories.

Screenshots

2
3
4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@nimishbongale nimishbongale requested review from a team as code owners November 21, 2020 14:46
@nimishbongale nimishbongale requested review from Dhruvi16, dhruvkb and zackkrida and removed request for a team November 21, 2020 14:46
@cc-open-source-bot cc-open-source-bot added this to In Progress in Vocabulary Planning Nov 21, 2020
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Nov 22, 2020
Copy link
Contributor

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimishbongale I made a little cleanup to the code to simplify some things, and to make each tomato/dark grey box fill its .column width-wise to give a better representation of the grid. Nice work!

@zackkrida zackkrida merged commit fc7f70f into master Dec 2, 2020
Active Sprint automation moved this from Code Review to Done Dec 2, 2020
Vocabulary Planning automation moved this from In Progress to Done Dec 2, 2020
@zackkrida zackkrida deleted the grid-docs branch December 2, 2020 02:29
@nimishbongale
Copy link
Contributor Author

nimishbongale commented Dec 2, 2020

@nimishbongale I made a little cleanup to the code to simplify some things, and to make each tomato/dark grey box fill its .column width-wise to give a better representation of the grid. Nice work!

Awesome! 😄

Thanks @zackkrida

@possumbilities possumbilities removed this from Done in Active Sprint Apr 24, 2024
@possumbilities possumbilities removed this from Done in Vocabulary Planning Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Grid/Page Layout Documentation
2 participants