New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.16] Make blocks rotatable for structures #1083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you very much! Just a couple of small nitpicks:
- We tend to use javax's Nonnull annotation instead of Jetbrain's one. JB's is probably better to use nowadays, but I do want to keep things consistent.
- Can you remove the
p
prefix from parameters? I think Parchment or ForgeGradle adds them in :/.
I assume these rotations only apply around the Y axis - we don't need to worry about a computer trying to face UP/DOWN?
Don't worry about 1.18 (unless it has changed massively!), as I can do that when merging things across.
Computers shouldn't be able to rotate UP/DOWN
Done (:
Kay! |
Thank you very much! |
For further explanation, see #1082
Every block should now be rotatable for structures. If you see that I missed one, just tell me (:
I also updated forge so that it supports newer versions of java
I'll open a PR for 1.18 in the next days