Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16] Make blocks rotatable for structures #1083

Merged
merged 5 commits into from May 1, 2022
Merged

[1.16] Make blocks rotatable for structures #1083

merged 5 commits into from May 1, 2022

Conversation

SirEndii
Copy link
Contributor

For further explanation, see #1082
Every block should now be rotatable for structures. If you see that I missed one, just tell me (:
I also updated forge so that it supports newer versions of java

I'll open a PR for 1.18 in the next days

@SirEndii
Copy link
Contributor Author

image
Left is normal, right is rotated by 270°

@SquidDev SquidDev added enhancement An extension of a feature or a new feature. area-Minecraft This affects CC's Minecraft-specific content. labels Apr 30, 2022
Copy link
Member

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much! Just a couple of small nitpicks:

  • We tend to use javax's Nonnull annotation instead of Jetbrain's one. JB's is probably better to use nowadays, but I do want to keep things consistent.
  • Can you remove the p prefix from parameters? I think Parchment or ForgeGradle adds them in :/.

I assume these rotations only apply around the Y axis - we don't need to worry about a computer trying to face UP/DOWN?

Don't worry about 1.18 (unless it has changed massively!), as I can do that when merging things across.

@SirEndii
Copy link
Contributor Author

SirEndii commented May 1, 2022

I assume these rotations only apply around the Y axis - we don't need to worry about a computer trying to face UP/DOWN?

Computers shouldn't be able to rotate UP/DOWN
So I just hope this will never happen :P

  • We tend to use javax's Nonnull annotation instead of Jetbrain's one. JB's is probably better to use nowadays, but I do want to keep things consistent.
  • Can you remove the p prefix from parameters? I think Parchment or ForgeGradle adds them in :/.

Done (:

Don't worry about 1.18 (unless it has changed massively!), as I can do that when merging things across.

Kay!
Nothing changed in between 1.16 to 1.18

@SquidDev SquidDev merged commit e909e11 into cc-tweaked:mc-1.16.x May 1, 2022
@SquidDev
Copy link
Member

SquidDev commented May 1, 2022

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants