Add support for Iris's new text sink API #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toad-dev
requested changes
Jun 8, 2022
src/main/java/dan200/computercraft/client/render/TileEntityMonitorRenderer.java
Outdated
Show resolved
Hide resolved
When an index buffer grows beyond the 2^16 boundary, the type is promoted from a SHORT to an INT. However, this type is not updated in any of the existing DirectVertexBuffers, so we mis-interpret the index buffer and render garbage. To fix this, we now store the index buffer object instead (and also acquire it during upload), and then read the type from that (which is guaranteed to be always correct). This is a little more aligned to how 1.19 does things (though 1.19 does bind during upload rather than first draw).
|
Good enough (TM).
|
toad-dev
approved these changes
Jun 8, 2022
|
Looks good to me 👍 |
|
Ahhh. I targetted the wrong branch for this. Don't know if you want me to recreate on top of |
|
gah! yeah just merge stable into 1.18.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed on Iris 1.2.5 as they change the vertex format of
RenderType.text, so us chucking bytes in directly won't work!I'd like to profile this before merging and check that the new virtual calls are JITted away, but otherwise this is good for review.
CCing @IMS212, in case they have any comments.