fix TurtleSuckCommand #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolsa
pushed a commit
to coolsa/cc-restitched
that referenced
this pull request
Jan 20, 2022
This uses Netty's global traffic shaping handlers to limit the rate at which packets can be sent and received. If the bandwidth limit is hit, we'll start dropping packets, which will mean remote servers send traffic to us at a much slower pace. This isn't perfect, as there is only a global limit, and not a per-computer one. As a result, its possible for one computer to use all/most bandwidth, and thus slow down other computers. This would be something to improve on in the future. However, I've spent a lot of time reading the netty source code and docs, and the implementation for that is significantly more complex, and one I'm not comfortable working on right now. For the time being, this satisfies the issues in cc-tweaked#33 and hopefully alleviates server owner's concerns about the http API. Remaining problems can either be solved by moderation (with help of the //computercraft track` command) or future updates. Closes cc-tweaked#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when using the TurtleSuckCommand and no inventory found