-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Popptr1 to save some bytes and ease parameter extraction #652
Conversation
Just noticed that there is may an issue with "strpbrk.s" (use of X-register). This leads to the question what happened to the function anyway: The description in the "funcref.sgml" is commented, there is no prototype to include and even the fastcall convention isn't applied. |
Remove? This is ANSI! |
Reverted change on "strpbrk.s". Together with documentation update, calling convention change and prototype introduction this is a nice extra story. |
libsrc/tgi/tgi_popxy.s
Outdated
sta ptr1 ; X | ||
stx ptr1+1 | ||
rts | ||
jmp popptr1 ; X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unintentionally added TABs again.
Nice :-))
Full ACK. |
@@ -13,7 +13,7 @@ | |||
FILEDES = 3 ; first free to use file descriptor | |||
|
|||
.importzp ptr1, ptr2, ptr3, tmp1 | |||
.import addysp, popax | |||
.import addysp, popax, poptr1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: popptr1
Sh... I have to hold back myself to mess around with foreign targets (wonder why there wasn't a build problem?). |
You might have a point here after all ;-)) ... see e949a3e |
Further savings are possible by exchange of assignments to ptr-variables like libsrc/cbm/rwcommon.s "ptr1<->ptr2" (but here you have to take care of dependent files).