Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore hashing of quotes and numbers in preprocessed output on master #120

Closed
jrosdahl opened this issue Jul 20, 2016 · 1 comment
Closed

Restore hashing of quotes and numbers in preprocessed output on master #120

jrosdahl opened this issue Jul 20, 2016 · 1 comment
Labels
bug Does not work as intended/documented
Milestone
3.3

Comments

@jrosdahl
Copy link
Member

See discussion in #113.

@itensionanders: Perhaps something you would like to have a look at?
@jrosdahl jrosdahl added the bug Does not work as intended/documented label Jul 20, 2016
@jrosdahl jrosdahl added this to the 3.3 milestone Jul 20, 2016
@afbjorklund
Copy link
Contributor

@jrosdahl : yeah, I think that I introduced it with 2197838

afbjorklund added a commit to afbjorklund/ccache that referenced this issue Jul 21, 2016
@afbjorklund
Including trailing quote and cpp flags in the hash
d22c926 
When looking for which headers are system headers ("3")
in the commit 2197838,
we skipped hashing the quote and flags... Restore that.
Shouldn't make any major difference, but changes the hash.

Closes ccache#120.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Does not work as intended/documented
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@jrosdahl @afbjorklund