Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to doctest 2.4.6 to fix ccache build with upcoming glibc >= 2.34 #825

Closed
Romain-Geissler-1A opened this issue Mar 22, 2021 · 2 comments
Closed

Upgrade to doctest 2.4.6 to fix ccache build with upcoming glibc >= 2.34 #825

Romain-Geissler-1A opened this issue Mar 22, 2021 · 2 comments
Labels
improvement Improvement that is not a bug fix or new feature
Milestone
4.2.1

Comments

@Romain-Geissler-1A
Copy link

Description

Hi,

I reported a build issue with doctest here doctest/doctest#473 which was just fixed in the just released doctest 2.4.6.

Would you please upgrade the embedded thirdpart doctest copy in ccache to fix this issue impacting ccache build ?

Thank you,
Romain
@Romain-Geissler-1A Romain-Geissler-1A added the improvement Improvement that is not a bug fix or new feature label Mar 22, 2021
@jrosdahl jrosdahl added this to the 4.2.1 milestone Mar 22, 2021
@jrosdahl
Copy link
Member

Sure. Thanks for reporting it upstream.

@Romain-Geissler-1A
Copy link
Author

Cool, thank you ;)

wlach pushed a commit to wlach/ccache that referenced this issue Nov 28, 2021
@jrosdahl @wlach
Upgrade to doctest 2.4.6
2a9f979 
Closes ccache#825.
This was referenced Nov 28, 2021
Closed
Merged
BKPepe pushed a commit to BKPepe/openwrt that referenced this issue Dec 7, 2021
@LGA1150 @BKPepe
ccache: update to 4.2.1
a80dd2c 
Update ccache to 4.2.1

While compiling on Gentoo, the ccache can not be compiled due to this
error:

/openwrt/build_dir/host/ccache-4.1/unittest/../src/third_party/doctest.h:4084:47: error: size of array 'altStackMem' is not an integral constant-expression
 4084 |         static char             altStackMem[4 * SIGSTKSZ];
      |                                               ^

This was fixed in ccache version 4.2.1 [1] by upgrading doctest [2].

[1] ccache/ccache#825
[2] doctest/doctest#473

Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [refresh patch]
(cherry picked from commit 3ebfd00)
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
[improved commit message]
@BKPepe BKPepe mentioned this issue Dec 7, 2021
Closed
jow- pushed a commit to openwrt/openwrt that referenced this issue Dec 29, 2021
@LGA1150 @chunkeey
ccache: update to 4.2.1
8166bbf 
Update ccache to 4.2.1

While compiling on Gentoo, the ccache can not be compiled due to this
error:

/openwrt/build_dir/host/ccache-4.1/unittest/../src/third_party/doctest.h:4084:47: error: size of array 'altStackMem' is not an integral constant-expression
 4084 |         static char             altStackMem[4 * SIGSTKSZ];
      |                                               ^

This was fixed in ccache version 4.2.1 [1] by upgrading doctest [2].

[1] ccache/ccache#825
[2] doctest/doctest#473

Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [refresh patch]
(cherry picked from commit 3ebfd00)
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
[improved commit message]
ArtelMike pushed a commit to ArtelMike/openwrt-1 that referenced this issue Jan 31, 2023
@LGA1150 @chunkeey
ccache: update to 4.2.1
bec579c 
Update ccache to 4.2.1

While compiling on Gentoo, the ccache can not be compiled due to this
error:

/openwrt/build_dir/host/ccache-4.1/unittest/../src/third_party/doctest.h:4084:47: error: size of array 'altStackMem' is not an integral constant-expression
 4084 |         static char             altStackMem[4 * SIGSTKSZ];
      |                                               ^

This was fixed in ccache version 4.2.1 [1] by upgrading doctest [2].

[1] ccache/ccache#825
[2] doctest/doctest#473

Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [refresh patch]
(cherry picked from commit 75e2763)
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
[improved commit message]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement that is not a bug fix or new feature
Projects
None yet
Milestone
4.2.1
Development

No branches or pull requests
2 participants
@jrosdahl @Romain-Geissler-1A