CI: add Appveyor script #247

peterbud · 2018-04-07T18:55:44Z

Currently not all test cases are running successfully, but we can monitor the build progress on Windows, see the results of unittests and test suites, and fix the remaining issues.

32-bit version: Build process example output
Unitests: FAILED: 3 tests
Test suits: base/CCACHE_NOHASHDIR fails and aborts

64-bit version: Build process example output
Unitests: fails pretty early at SUITE: argument_processing
Test suits: base/CCACHE_NOHASHDIR fails and aborts

* 3.4-maint: Hash preprocessed headers located in “.gch directories” correctly

* 3.4-maint: Fix paths to bundled zlib

* 3.4-maint: The Dockerfile was moved to a subdirectory

Having large precompiled header files slows down direct mode off CCache considerably. Allow CCache to check against a (much smaller) pre-computed checksum file instead of the precompiled header file itself. This checksum file will be used in the manifest instead of the actual precompiled header file. Note that to make this to work, the build system needs to keep a checksum file in sync with the precompiled header. The behavior can be activated by the `pch_external_checksum` option.

This should make them nicely rendered in the GitHub file tree.

* 3.4-maint: Change extension of AsciiDoc files to .adoc

* 3.4-maint: cleanup: Remove special-casing of files from ccache 2.x Fix debug_prefix_map suite Improve AsciiDoc markup Improve man page generation Remove redundant .gitignore entries

* 3.4-maint: Update NEWS Clean up Support out-of-source builds Be consistent with “Clang” and “NVCC” names in NEWS Don’t apply Clang workaround for PCH dependencies for other compilers

* 3.4-maint: Clean up win32: Silence compiler warnings cleanup: Improve robustness when multiple cleanups run concurrently cleanup: Log size before cleaning Add x_try_unlink utility function test: Use helper functions instead of custom code test: Improve error messages from expect_{equal,different}_files

* 3.4-maint: Prepare for v3.4.2 direct .i mode: Don't create tmp.cpp_stderr file at all

Currently not all test cases are running successfully, but we can monitor the progress

afbjorklund · 2018-04-08T08:26:58Z

Looks like a good start! Can you add a MSYS (Cygwin) build too, using the regular test framework ?

script:
    - ./autogen.sh
    - ./configure $HOST
    - make
    - make ${TEST:-test}

That platform has some quirks (missing symlinks, PE executable format) that would be nice to test...

afbjorklund · 2018-04-08T08:30:13Z

Also, if you could rename it to .appveyor.xml it would "hide" the clutter.

The test part should probably be integrated/moved somewhere as well ?

peterbud · 2018-04-08T08:33:28Z

For hiding the clutter: it's pretty common to hide CI related stuff in a separate subfolder, all CI frameworks can handle if files are in a specific subfolder in the source tree, example here

afbjorklund · 2018-04-08T10:18:52Z

@peterbud : yeah, we have a .travis folder for that already.
And of course the good ole "misc" for stuff that didn't fit...

But I think only .appveyor.yml works right out-of-the-box ?
https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming

afbjorklund · 2018-04-08T10:20:26Z

ci-script-windows.sh

+    make unittest/run.exe
+    ./unittest/run.exe -v && TRUE
+
+    ../test/run -v && TRUE


Most likely this whole block should just run make test, rather than hard-coding internal binaries and targets ?

afbjorklund · 2018-04-08T10:21:54Z

appveyor.yml

+    MSYS2_ARCH: x86_64
+
+build_script:
+  - C:\msys64\usr\bin\pacman --noconfirm --sync --refresh --refresh --sysupgrade --sysupgrade


duplicate --refresh ?

peterbud · 2018-04-08T10:37:06Z

@afbjorklund : You can configure the location of the appveyor.xml when you enable Appveyor for a given Github repo:

That;s for example how I'm using it for darktable.

Let me know your preference, and I'll move the files there.

afbjorklund · 2018-04-08T10:37:08Z

As for the CCACHE_NOHASHDIR and other Windows test failures, most have been fixed in 217a260
They are rmostly elated to paths, either the wrong delimiter (/ \) is being used - or it needs "escaping".

I will clean that up into individual commits - after we have gotten the MinGW and MSYS merged (#246).
Also seems like my autoconf check for GetFinalPathNameByHandle doesn't work properly anymore...

checking for GetFinalPathNameByHandleW... no

From a21da6f
The fallback code also had some stupid bug, that converted C:\Users to sers

afbjorklund · 2018-04-08T10:42:24Z

Fixing Windows build is related to #122

This PR is the same as/replaces #69

peterbud · 2018-04-08T10:55:25Z

@afbjorklund I have added MSYS to the CI matrix, based on your suggestions I have corrected the script. Also I have realized that you had in an earlier (not yet merged) PR #246 a solution for fixing log printing: I have taken that here as well to have the same code base.

afbjorklund · 2018-04-08T11:17:00Z

Basically that log printing stuff is in every branch, guess we should just give up on "%z" and go for the portable printf stuff instead. But it's also annoying when you can't use all the regular things, of course.

afbjorklund · 2018-04-18T18:37:51Z

I think this will be a good addition to the Travis builds, once those have been cleaned up...
Currently travis will only build the unittest, but not run it. But it might be able to in Wine.
I think some of the latest changes for MSYS/MinGW might actually have broken Windows,
but I suppose that can be cleaned up by adding some kind of "vanilla" Win build target too ?

i.e. without bash, with all the legacy DOS weirdness. and then just execute unittest/run.exe

Though that is a much bigger change, than "just" fixing the Cygwin and Windows build targets.

peterbud · 2018-04-19T08:41:04Z

The MINGW32/MINGW64 builds are native builds, and if you run unittest/run.exe from the bash is the the same if you would run that from command prompt or from powershell. Even I believe we can add powershell script to the CI if you want, but in order to do that we need to make a proper deployment in the CI script, as the compiled executable has dependencies (MSYS2 runtime DLL and zlib) which needs to be copied next to the executable, as they are not on the PATH if running from a simple command prompt/powershell.

Let me know if you want to add a powershell/cmd prompt test part.

Also based on my tests some of the test cases are broken on Windows, but not too many, so with thorough work we can fix them one-by-one.

afbjorklund · 2018-04-19T19:39:30Z

Just thought I saw some additional issues, when running it with Wine ? (plus some Wine bugs)

Anyway, the priorities are something like the following:

Fix the Cygwin build, this should be pretty easy and goes into 3.4
Mostly it is about missing symlinks, that funky .exe extension and the PE executable format...
Try to address the issues running with MinGW (both 32 and 64)
This might require some additional investigation of DOS quirks like paths and batch files etc.
Perhaps look into supporting Windows as a real developer platform.
This is the final and least likely option, since it requires a lot of changes. But the goal of Cleaning up the build system #169

* 3.4-maint: Use double when calculating cache thresholds Add a 32-bit build target, using multilib (-m32) Convert float config to double, add rounding Upgrade clang to 5.0, for the Travis docker Make sure to export ASAN_OPTIONS properly Add small helper to run all Travis tests Make sure to call configure with right path Add a travis-build container, for running locally Look for -fdebug-prefix-map feature explicitly Improve the Travis build matrix Fix log printing of before/after cleanup Remove irrelevant variable assignment in wipe_dir win32: Fix CCACHE_COMPILERCHECK=mtime test case

peterbud · 2018-05-02T05:53:00Z

I have updated this to resolve the conflict to master, but I'm not convinced that I did it correctly. What is your preference with this PR?

jrosdahl · 2019-07-28T12:34:54Z

I'm going through old open PRs and have now come to this one.

I have updated this to resolve the conflict to master, but I'm not convinced that I did it correctly.

No, the diff doesn't look right. Also, it seems be based on 3.4-maint, not master.

What is your preference with this PR?

I don't know, frankly. I have now written a kind of brain dump on my view on Windows support here: #447.

peterbud · 2019-07-29T22:54:07Z

Let's close it here. I'll open a new PR with an updated CI proposal

jrosdahl and others added 15 commits February 17, 2018 10:51

Rename CCACHE_CC to CCACHE_COMPILER

d653cfa

Merge branch '3.4-maint'

822a991

* 3.4-maint: Hash preprocessed headers located in “.gch directories” correctly

Merge branch '3.4-maint'

cba1ea3

* 3.4-maint: Fix paths to bundled zlib

Merge branch '3.4-maint'

3b4f2cc

* 3.4-maint: The Dockerfile was moved to a subdirectory

Apply code review suggestions

8f0b477

Update NEWS

018c74e

Change extension of AsciiDoc files to .adoc

552840b

This should make them nicely rendered in the GitHub file tree.

Merge branch '3.4-maint'

f351b2a

* 3.4-maint: Change extension of AsciiDoc files to .adoc

Merge branch '3.4-maint'

38e91e2

* 3.4-maint: cleanup: Remove special-casing of files from ccache 2.x Fix debug_prefix_map suite Improve AsciiDoc markup Improve man page generation Remove redundant .gitignore entries

Merge branch '3.4-maint'

a4a159a

* 3.4-maint: Update NEWS Clean up Support out-of-source builds Be consistent with “Clang” and “NVCC” names in NEWS Don’t apply Clang workaround for PCH dependencies for other compilers

Merge branch '3.4-maint'

5dc502e

* 3.4-maint: Prepare for v3.4.2 direct .i mode: Don't create tmp.cpp_stderr file at all

win32: Add Windows/MinGW ifdefs, to make it build

bfcf5a5

CI: add Appveyor script

e253be0

Currently not all test cases are running successfully, but we can monitor the progress

afbjorklund reviewed Apr 8, 2018

View reviewed changes

peterbud added 2 commits April 8, 2018 12:46

win32: use the same conditionals as afbjorklund

994ba68

CI: Add MSYS to the matrix, remove duplicated arguments

d7e7fb4

jrosdahl and others added 5 commits April 23, 2018 22:04

Print the time when stats last updated

7ea35e0

Simplify logic

b8a2492

Update NEWS

5779e97

Merge branch 'master' of https://github.com/ccache/ccache into appveyor2

3241a58

jrosdahl added os: windows Related to building or running on Windows portability Affects portability of building or using Ccache labels May 7, 2018

jrosdahl mentioned this pull request Sep 2, 2018

Figure out what to do with Windows-related issues #305

Closed

afbjorklund mentioned this pull request Sep 2, 2018

Travis: use wine for mingw unittest #256

Closed

jrosdahl mentioned this pull request Jul 28, 2019

Add appveyor, Windows ci, support. #69

Closed

peterbud closed this Jul 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: add Appveyor script #247

CI: add Appveyor script #247

peterbud commented Apr 7, 2018

afbjorklund commented Apr 8, 2018

afbjorklund commented Apr 8, 2018

peterbud commented Apr 8, 2018

afbjorklund commented Apr 8, 2018 •

edited

afbjorklund Apr 8, 2018

afbjorklund Apr 8, 2018

peterbud commented Apr 8, 2018 •

edited

afbjorklund commented Apr 8, 2018 •

edited

afbjorklund commented Apr 8, 2018 •

edited

peterbud commented Apr 8, 2018

afbjorklund commented Apr 8, 2018

afbjorklund commented Apr 18, 2018

peterbud commented Apr 19, 2018

afbjorklund commented Apr 19, 2018

peterbud commented May 2, 2018

jrosdahl commented Jul 28, 2019

peterbud commented Jul 29, 2019

CI: add Appveyor script #247

CI: add Appveyor script #247

Conversation

peterbud commented Apr 7, 2018

afbjorklund commented Apr 8, 2018

afbjorklund commented Apr 8, 2018

peterbud commented Apr 8, 2018

afbjorklund commented Apr 8, 2018 • edited

afbjorklund Apr 8, 2018

Choose a reason for hiding this comment

afbjorklund Apr 8, 2018

Choose a reason for hiding this comment

peterbud commented Apr 8, 2018 • edited

afbjorklund commented Apr 8, 2018 • edited

afbjorklund commented Apr 8, 2018 • edited

peterbud commented Apr 8, 2018

afbjorklund commented Apr 8, 2018

afbjorklund commented Apr 18, 2018

peterbud commented Apr 19, 2018

afbjorklund commented Apr 19, 2018

peterbud commented May 2, 2018

jrosdahl commented Jul 28, 2019

peterbud commented Jul 29, 2019

afbjorklund commented Apr 8, 2018 •

edited

peterbud commented Apr 8, 2018 •

edited

afbjorklund commented Apr 8, 2018 •

edited

afbjorklund commented Apr 8, 2018 •

edited