Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence with modifier keys not working #140

Closed
vicramon opened this issue Jul 2, 2013 · 5 comments
Closed

Sequence with modifier keys not working #140

vicramon opened this issue Jul 2, 2013 · 5 comments

Comments

@vicramon
Copy link

vicramon commented Jul 2, 2013

I've run into the following issue:

Certain modifier keys + another key followed by any sequence won't work.

For example:

ctrl+r a won't trigger an event.

However, all of these sequences do work:

ctrl r a
ctrl+r
r a

I am using Chrome with an Apple keyboard. Why might this be happening? Is this feature not built yet?

Thanks.

@ccampbell
Copy link
Owner

Thanks for the report. I will take a look later... should definitely work. It is possible that I broke this by accident with eee5c19 when fixing #130

@vicramon
Copy link
Author

vicramon commented Jul 3, 2013

Thanks for taking a look. I downloaded the new version and am still seeing the issue though.

What's odd is that the tests all passed in my browser (the latest Chrome, version 27.0.1453.116). I tried it with the same key sequence in the test, ctrl+b a, but no luck.

Is this working in the browser for you?

@ccampbell
Copy link
Owner

Ugh you are totally right. I had this working. Will fix.

@ccampbell ccampbell reopened this Jul 3, 2013
@ccampbell
Copy link
Owner

K try now.

@vicramon
Copy link
Author

vicramon commented Jul 3, 2013

Awesome, it's working now. Thanks!

ccampbell added a commit that referenced this issue Jul 13, 2013
After 315ae62 there is never a case
under normal usage where this should be needed.

I added it for dealing with #140 when I was explicitly checking the
character for keypress events which proved to be unreliable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants