Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalized keybindings work for binds registered with "keypress" action but not for "keydown" action #430

Open
mgsloan opened this issue Aug 28, 2018 · 0 comments

Comments

@mgsloan
Copy link

mgsloan commented Aug 28, 2018

Just letting you know about this inconsistency! If I bind keypress actions specified with an uppercase character, like "H", it works. However, if I bind "keydown" actions, these bindings do not work, instead I have to use "h".

Why am I using keydown instead of keypress? Well, recently I encountered some funky behavior where the keypress handler wasn't working in firefox - I suspect that this was a change in behavior the site that I am extending - mgsloan/todoist-shortcuts#40 - so that probably not a mousetrap issue. Curiously, I still got key repeat even when using "keydown" actions, which was surprising.

Sorry for not including a more direct repro in this issue report. This is more of letting folks know there's an issue like this - the workaround for me was quite straightforward. Instead I just use shift+lower instead of the uppercase form of the keybinding.

Note that I have a modified version of mousetrap. However, I am pretty confident that this is not due to any You might be interested in what I've added, let me know if I should open some PRs - master...mgsloan:master

mgsloan added a commit to mgsloan/todoist-shortcuts that referenced this issue Aug 28, 2018
@mgsloan mgsloan changed the title Capitalized keybindings work for binds registered with "keypress" action but now for "keydown" action Capitalized keybindings work for binds registered with "keypress" action but not for "keydown" action Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant