Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #123 fix('too much recursion' fix) #124

Closed
wants to merge 1 commit into from

Conversation

vodkabears
Copy link

@ccampbell
Copy link
Owner

How does the performance seem in general? The 100 was definitely a somewhat arbitrary number, but the lower the number, the longer it takes to highlight.

I wonder if there is still a bug, and this solution just masks it.

@vodkabears
Copy link
Author

each 100 times:
http://jsfiddle.net/dfrost/t45fk/

each 50 times(sources from the fork):
http://jsfiddle.net/dfrost/yztSJ/

A bit slower. Also i've tested it on 10000 lines of a code - still no errors.

There is no bug, just lots of recursion.

@ccampbell
Copy link
Owner

I believe this should work correctly in version 2.0 which was just released

@ccampbell ccampbell closed this Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants