update haskell language. #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- haskell pragmas has some reserved words, so they were hard coded added to its matcher. - generalized entity.name to match ghc options pragma.
- removed '$' from the pattern (pragmas can be anywhere)
|
I just updated Rainbow to version 2.0. I would like to get these fixes out. Could you do me a favor and update your branch with upstream and reapply the changes? It should be fairly straight forward. Also can you update the haskell language grammar to use 4 spaces instead of tabs? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR should fix #168 and #169, and update the haskell language support.