Update gulp-git version #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to build on Node v8 (see stephenlacy/gulp-git#164).
lucaswerkmeister
added a commit
to eclipse-archived/ceylon
that referenced
this pull request
Jul 26, 2017
This is a custom build of Rainbow, built from the master branch of my fork [1], which includes ccampbell/rainbow#209 (fix for #6559) and ccampbell/rainbow#222 (build system fix). The build does not include any languages, since the only languages we need (ceylon and bnf) we define ourselves. This fixes #6559. [1]: https://github.com/lucaswerkmeister/rainbow/tree/e00fd37207be02236db30b2a8209b425a3e9b20f
lucaswerkmeister
added a commit
to eclipse-archived/ceylon
that referenced
this pull request
Feb 24, 2018
This is a custom build of Rainbow, built from a repository based on the v2.1.3 tag of Rainbow with ccampbell/rainbow#209 (fix for #6559) and ccampbell/rainbow#222 (build system fix) merged. The diff to the v2.1.3 tag (excluding the test/ directory) is: diff --git a/package.json b/package.json index d0fcea2..66e3289 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "gulp-autoprefixer": "3.1.0", "gulp-bump": "2.1.0", "gulp-eslint": "2.0.0", - "gulp-git": "1.7.2", + "gulp-git": "2.4.1", "gulp-inject-string": "1.1.0", "gulp-sass": "2.3.2", "karma": "0.13.22", diff --git a/src/util.js b/src/util.js index 8660224..9f23e49 100644 --- a/src/util.js +++ b/src/util.js @@ -141,7 +141,7 @@ export function keys(object) { */ export function replaceAtPosition(position, replace, replaceWith, code) { const subString = code.substr(position); - return code.substr(0, position) + subString.replace(replace, replaceWith); + return code.substr(0, position) + subString.replace(replace, replaceWith.replace(/\$/g, '$$$$')); } /** This fixes #6559.
lucaswerkmeister
added a commit
to eclipse-archived/ceylon
that referenced
this pull request
Feb 24, 2018
This is a custom build of Rainbow, built from a repository based on the v2.1.3 tag of Rainbow with ccampbell/rainbow#209 (fix for #6559) and ccampbell/rainbow#222 (build system fix) merged. The diff to the v2.1.3 tag (excluding the test/ directory) is: diff --git a/package.json b/package.json index d0fcea2..66e3289 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "gulp-autoprefixer": "3.1.0", "gulp-bump": "2.1.0", "gulp-eslint": "2.0.0", - "gulp-git": "1.7.2", + "gulp-git": "2.4.1", "gulp-inject-string": "1.1.0", "gulp-sass": "2.3.2", "karma": "0.13.22", diff --git a/src/util.js b/src/util.js index 8660224..9f23e49 100644 --- a/src/util.js +++ b/src/util.js @@ -141,7 +141,7 @@ export function keys(object) { */ export function replaceAtPosition(position, replace, replaceWith, code) { const subString = code.substr(position); - return code.substr(0, position) + subString.replace(replace, replaceWith); + return code.substr(0, position) + subString.replace(replace, replaceWith.replace(/\$/g, '$$$$')); } /** This fixes #6559.
lucaswerkmeister
added a commit
to eclipse-archived/ceylon
that referenced
this pull request
Feb 24, 2018
This is a custom build of Rainbow, built from a repository based on the 2.1.3 tag of Rainbow with ccampbell/rainbow#209 (fix for #6559) and ccampbell/rainbow#222 (build system fix) merged. The diff to the 2.1.3 tag (excluding the test/ directory) is: diff --git a/package.json b/package.json index d0fcea2..66e3289 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "gulp-autoprefixer": "3.1.0", "gulp-bump": "2.1.0", "gulp-eslint": "2.0.0", - "gulp-git": "1.7.2", + "gulp-git": "2.4.1", "gulp-inject-string": "1.1.0", "gulp-sass": "2.3.2", "karma": "0.13.22", diff --git a/src/util.js b/src/util.js index 8660224..9f23e49 100644 --- a/src/util.js +++ b/src/util.js @@ -141,7 +141,7 @@ export function keys(object) { */ export function replaceAtPosition(position, replace, replaceWith, code) { const subString = code.substr(position); - return code.substr(0, position) + subString.replace(replace, replaceWith); + return code.substr(0, position) + subString.replace(replace, replaceWith.replace(/\$/g, '$$$$')); } /** This fixes #6559.
lucaswerkmeister
added a commit
to eclipse-archived/ceylon
that referenced
this pull request
Feb 24, 2018
This is a custom build of Rainbow, built from a repository based on the 2.1.3 tag of Rainbow with ccampbell/rainbow#209 (fix for #6559) and ccampbell/rainbow#222 (build system fix) merged. The diff to the 2.1.3 tag (excluding the test/ directory) is: diff --git a/package.json b/package.json index d0fcea2..66e3289 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "gulp-autoprefixer": "3.1.0", "gulp-bump": "2.1.0", "gulp-eslint": "2.0.0", - "gulp-git": "1.7.2", + "gulp-git": "2.4.1", "gulp-inject-string": "1.1.0", "gulp-sass": "2.3.2", "karma": "0.13.22", diff --git a/src/util.js b/src/util.js index 8660224..9f23e49 100644 --- a/src/util.js +++ b/src/util.js @@ -141,7 +141,7 @@ export function keys(object) { */ export function replaceAtPosition(position, replace, replaceWith, code) { const subString = code.substr(position); - return code.substr(0, position) + subString.replace(replace, replaceWith); + return code.substr(0, position) + subString.replace(replace, replaceWith.replace(/\$/g, '$$$$')); } /** The build does not include any languages, since the only languages we need (ceylon and bnf) we define ourselves. This fixes #6559.
|
Oops. This was taken care of in b2ce733, release was published today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to build on Node v8 (see stephenlacy/gulp-git#164).