Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comps algorithm to save instruno in addition to parid #235

Closed
jeancochrane opened this issue Apr 26, 2024 · 1 comment
Closed

Update comps algorithm to save instruno in addition to parid #235

jeancochrane opened this issue Apr 26, 2024 · 1 comment
Assignees

Comments

@jeancochrane
Copy link
Contributor

It's currently difficult to work with the output of our comps algorithm because it saves the PIN of each comp sale (parid) but not the doc number (instruno), so we have to infer which sale is the comp if the PIN has multiple sales in the training set. It would be easier to use the comps data if we also saved the doc number so that each comp could be uniquely tied to a specific sale.

@jeancochrane jeancochrane self-assigned this Apr 26, 2024
@jeancochrane
Copy link
Contributor Author

Superseded by https://github.com/ccao-data/pinval/issues/7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant