-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for compatibility with Hapi 8.0 (WIP) #99
Updates for compatibility with Hapi 8.0 (WIP) #99
Conversation
Very nice! Is it just me or does it look like the verify method doesn't wait a proper amount for the hapi server to startup? Often getting this error when verifying:
|
It looks like the ECONNREFUSED error existed prior to upgrading to Hapi 8. #98 was opened a few days ago. I tried running the unmodified workshop with Hapi 7 and occasionally got the error as well. I'll dig around and see if I can find a fix |
Just found a problem with cookies (the section, not the real ones). Seems like the validation just passes the cookie 'session=eyJrZXkiOiJtYWtlbWVoYXBpIn0=; Max-Age=0; Expires=Sat, 13 Dec 2014 19:27:21 GMT; Domain=localhost; Path=/{path*}' as it was received: https://github.com/hapijs/makemehapi/blob/7da6437aadba0dfe2636dbb881302de0621c5a31/exercises/cookies/exercise.js#L86 This is the same thing as telling the server that there is a Max-Age, Expires, etc. value in the data set. That wasn't a problem but some time in the last months the default settings for cookies where that the value has to be strict and the value for the "Expires" field doesn't match that setting. |
This is no longer WIP in progress. All the exercises should with Hapi 8 now. |
hey @linclark any chance you could review this so folks can start learning hapi 8? |
you can feel free to commit |
@@ -1,7 +1,10 @@ | |||
var Hapi = require('hapi'); | |||
var server = new Hapi.Server(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server should be after your module definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing
Overall looks pretty good, just a few stylist things to follow hapi standards. |
Updates for compatibility with Hapi 8.0 (WIP)
Exercises updated:
I'll finish the others tomorrow or this weekend.
Fixes #100