Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SAVE/DONE button prevents selecting faces in the top/left corner #28

Open
Robert-Nelson opened this issue Jan 6, 2022 · 2 comments

Comments

@Robert-Nelson
Copy link

The SAVE/DONE button should be moved to the bottom of the picture where it is far less likely to cover part of a face.

Robert-Nelson added a commit to Robert-Nelson/MugShot2 that referenced this issue Jan 13, 2022
Merge commit '3c9cf8ad314' into working
@cccraig
Copy link
Owner

cccraig commented Feb 12, 2022

We should try to fix this more robustly; placing the save button in the bottom of the picture would be less likely to cover a face but we're still likely to hit the same problem at some point.

Perhaps this could be rolled in with fixing #21. I'm thinking that could be some sort of modal that could be moved out of the way and it could provide info who's in the picture, the bounding box for their face, the save option, % confidence in identity (If I get facial recognition working), etc.

@Robert-Nelson
Copy link
Author

BTW, I have facial recognition working. I did it in two parts, detection and matching. Detection creates the entry in face_tag_positions with tag_id set to null. I added a menu block for MugShot with two items. "Unidentified People" and "Unconfirmed Matched People. The first link displays an index page of all faces with null for a tag_id. The latter displays all the ones with confirmed set to false. This only happens with software created ones using detection and mapping. In the "Capone" UI there is an additional icon (checkmark) that sets confirmed to true. Confirmed faces have green bounding boxes, the others are red. The actual detection and matching is done by a separate python program that can be run on the same machine or a separate more powerful one or one that you have root access on.

cccraig added a commit that referenced this issue Oct 30, 2023
Fix Issue #28 - SAVE/DONE button blocks faces in upper left corner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants