Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'children' of undefined #37

Closed
ghost opened this issue Apr 8, 2014 · 1 comment
Closed

Uncaught TypeError: Cannot read property 'children' of undefined #37

ghost opened this issue Apr 8, 2014 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Apr 8, 2014

When Quote Threading is disabled, every time the thread updates and adds a new reply you get a Uncaught TypeError: Cannot read property 'children' of undefined in the console.

typerror

Everything seems to be working but I don't think it should be printing this error to the console. Tested on a fresh Chrome 33, 4chan X 1.7.3 and default settings except for Quote Threading disabled.

@ccd0 ccd0 added the bug label Apr 20, 2014
@ccd0
Copy link
Owner

ccd0 commented Nov 3, 2014

Apparently it's an incompatibility between 4chan X and 4chan's highlight-by-ID code. The latter assumes there are two name fields (one desktop and one mobile), but 4chan X only generates the desktop part. Although not the cause of this error, it also assumes the .highlight class is never the last item in the class list, and that no additional CSS classes are added to the element containing the poster ID. Rather than work around all this, as of v1.9.10.0 (commit aaeff46) I've opted to disable 4chan's highlight-by-ID code and add the functionality to 4chan X. So this error should no longer occur.

@ccd0 ccd0 closed this as completed Nov 9, 2014
ccd0 pushed a commit that referenced this issue Jun 13, 2016
loveisover.me archive is now located at archive.loveisover.me, also updated to reflect that search is working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant