add interface of validation rule #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Otherwise, this notify channel is absent of tokens.
710leo
added a commit
that referenced
this pull request
Jul 14, 2023
* add MinIO dashboard and alert rules based on categraf acquisition (#1625) * set alert_rule.promql empty * code refactor * docs: update built-in alert rule * add interface of validation rule (#1606) * add interface of validation rule --------- Co-authored-by: shardingHe <wangzihe@flashcat.cloud> Co-authored-by: Yening Qin <710leo@gmail.com> * refactor consume --------- Co-authored-by: 青牛踏雪 <56914892+cyancow@users.noreply.github.com> Co-authored-by: Ulric Qin <ulric.qin@gmail.com> Co-authored-by: shardingHe <125482062+shardingHe@users.noreply.github.com> Co-authored-by: shardingHe <wangzihe@flashcat.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add interface of validation rule.
What this PR does / why we need it:
Validate the rule before saving, similar to checking for the absence of notify channel tokens.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
If all users are missing certain notify channel configurations it will not validate (each channel should be configured with at least one user).