Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtin-metrics): add CRUD operations for entity classes #1900

Closed
wants to merge 15 commits into from

Conversation

motongxue
Copy link

What type of PR is this?
new feature about builtin-metrics.
What this PR does / why we need it:

With a builtin-metrics management.

models/builtin_metric.go Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
docker/initsql/a-n9e.sql Outdated Show resolved Hide resolved
docker/initsql/a-n9e.sql Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
models/builtin_metric.go Outdated Show resolved Hide resolved
docker/initsql/a-n9e.sql Outdated Show resolved Hide resolved
@motongxue motongxue changed the title feat(builtin-metrics): add entity operations and insert method feat(builtin-metrics): add CRUD operations for entity classes Mar 29, 2024
models/builtin_metric.go Outdated Show resolved Hide resolved
@moonming
Copy link

Some of the commits in this PR were completed during working hours as an intern at our company, and no declaration was made. According to the intellectual property agreement signed by @motongxue, the intellectual property rights of this PR belong to the commercial company rather than to the individual. Please close this PR.

@motongxue motongxue closed this Mar 30, 2024
@Zheaoli
Copy link

Zheaoli commented Apr 3, 2024

Some of the commits in this PR were completed during working hours as an intern at our company, and no declaration was made. According to the intellectual property agreement signed by @motongxue, the intellectual property rights of this PR belong to the commercial company rather than to the individual. Please close this PR.

Actually, if you and your partner have accept the PR who is writing by the non-API7 employer in their work time for the apisix project, you need to remove the code first. And we can discuss the intellectual property agreement

Otherwise, the intellectual property agreement in your org is just kind of joke

@motongxue motongxue deleted the feat-builtin-metrics branch April 3, 2024 04:49
@qylife
Copy link

qylife commented Apr 3, 2024

Some of the commits in this PR were completed during working hours as an intern at our company, and no declaration was made. According to the intellectual property agreement signed by @motongxue, the intellectual property rights of this PR belong to the commercial company rather than to the individual. Please close this PR.

According to your description, please ask the author of every PR which writing by the non-API7 employer in apisix and tell them not to contribute code to apisix during business hours.

Otherwise, the author of PR violates the intellectual property agreement.

@zhenrong-wang
Copy link

Legal should step in and provide formal explanations.

@Xuanwo
Copy link

Xuanwo commented Apr 3, 2024

Some of the commits in this PR were completed during working hours as an intern at our company, and no declaration was made. According to the intellectual property agreement signed by @motongxue, the intellectual property rights of this PR belong to the commercial company rather than to the individual. Please close this PR.

Hello @moonming, it's acceptable to state that API7 prohibits contributing to open-source projects during business hours. However, it would be more appropriate if you discussed this first with @motongxue privately before asking the repository maintainer to close the PR directly and publicly.

@cubxxw
Copy link

cubxxw commented Apr 3, 2024

Some of the commits in this PR were completed during working hours as an intern at our company, and no declaration was made. According to the intellectual property agreement signed by @motongxue, the intellectual property rights of this PR belong to the commercial company rather than to the individual. Please close this PR.

I agree with @Xuanwo that if you ask for PR to be shut down publicly, it might be a better solution to communicate privately with the people involved first.This approach not only helps maintain a positive atmosphere in the community, but also provides more room for both sides to resolve disputes, potentially avoiding unnecessary public conflict.

I observed that the intern might be a developer of the advanced version of apisix,Actually responsible for apisix closed source premium version of the deployment of a lot of https://github.com/apache/apisix/pulls?q=is%3Apr+sort%3Aupdated-desc+author%3Amotongxue

For commercial open source companies, open source contribution is an important force to promote the development of technology, and many companies also encourage employees to participate in open source projects.On the other hand, companies also need to protect their commercial interests from inadvertent disclosure of intellectual property.Therefore, it is imperative to establish clear company policies and guidelines that both support open source contributions and protect company interests.


中文描述

我认同 @Xuanwo 的观点,即在公开要求关闭PR之前,首先私下与涉事人员沟通可能是更佳的解决方式。这种做法不仅有助于保持社区的积极氛围,也为双方提供了更多解决争议的空间,可能避免不必要的公开冲突。

我观察到实习生可能是 apisix 的高级版的开发,实际上负责 apisix 闭源的高级版部分的部署很多 https://github.com/apache/apisix/pulls?q=is%3Apr+sort%3Aupdated-desc+author%3Amotongxue

而对于商业化的开源公司而言,开源贡献是推动技术发展的重要力量,许多公司也鼓励员工参与开源项目。另一方面,公司也需要保护自身的商业利益,避免知识产权的无意泄露。因此,制定明确的公司政策和指导原则,既支持开源贡献又保护公司利益,是非常必要的。

@Riessarius
Copy link

Riessarius commented Apr 3, 2024

Some of the commits in this PR were completed during working hours as an intern at our company, and no declaration was made. According to the intellectual property agreement signed by @motongxue, the intellectual property rights of this PR belong to the commercial company rather than to the individual. Please close this PR.

In my humble opinion, it is usually more appropriate to discuss and act upon this matter between yourselves first instead of abruptly bringing it up to the public. All contributions, regardless of their intellectual property owners, are subject to the licenses adopted by the projects they belong to. Hence the organisers of the project do not bear whatsoever the responsibility of the direct compliance of the internal disciplines of your company. Open source communities often value equality and fairness greatly, and it is wise to pay respect to its culture and customs when you communicate with the members. Therefore a prior internal discussion should be a more appropriate action, for your reference kindly. @moonming

@lesismal
Copy link

lesismal commented Apr 3, 2024

@moonming Most developers have a job from a company, agree with what @Zheaoli said.
If you do such suck things here, you should check apisix's management yourself first.

@motongxue
Copy link
Author

I don't know why this PR suddenly became popular, thank you all for the discussion of open source. But this discussion under the PR of this repository has affected the work of the repository itself, and I hope you can go elsewhere to discuss it. Thank you again!

@ccfos ccfos locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants