New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FMDB: now with more documentation! #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great, Thank you! |
Sorry I haven't pulled this yet- I got awful busy recently. I try to get to it asap though. |
cool ;) |
ccgus
added a commit
that referenced
this pull request
Apr 30, 2011
FMDB: now with more documentation!
Finally got this done. Did you write any tests at all for executeUpdateWithFormat? I'd like to add them to main.m if you did. |
petersondrew
pushed a commit
to petersondrew/fmdb
that referenced
this pull request
Jan 9, 2012
FMDB: now with more documentation!
wmathurin
pushed a commit
to wmathurin/fmdb
that referenced
this pull request
Jul 11, 2017
Updating FMDB fork to FMDB 2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several changes in these commits:
-[FMDatabase validateSQL:error:]
). ReturnsYES
if the passed SQL is valid,NO
otherwise.-[FMResultSet numberOfColumns]
)-[FMDatabase executeQueryWithFormat:]
and-[FMDatabase executeUpdateWithFormat:]
). This allows you to not worry about boxing non-object values inNSNumbers
before passing them in to FMDB. For example:[db executeUpdateWithFormat:@"insert into myTable values (%d, %s)", 42, "simple string"];
-[FMResultSet objectForColumnName:]
to-[FMResultSet objectForColumn:]
to be consistent with the other similar methodsYou may need to do a bit of formatting cleanup, but on the whole I believe the changes are worthwhile. :)