Fix deployment targets and CocoaPods integration #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject's default deployment target settings
tstump-phunware
commented
Jun 12, 2021
| @@ -620,14 +620,10 @@ | |||
| }; | |||
| }; | |||
| buildConfigurationList = 1DEB927808733DD40010E9CD /* Build configuration list for PBXProject "fmdb" */; | |||
| compatibilityVersion = "Xcode 8.0"; | |||
| developmentRegion = English; | |||
| compatibilityVersion = "Xcode 12.0"; | |||
There was a problem hiding this comment.
Bumped the compatibility since Apple requires all submissions to be built using Xcode 12 or newer as of April 21, 2021. (ref: https://developer.apple.com/news/?id=ib31uj1j)
tstump-phunware
commented
Jun 12, 2021
| @@ -917,7 +918,10 @@ | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_PARAMETER = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | |||
There was a problem hiding this comment.
Lines 921, 922, and 923:
Moved the deployment targets to be defined at the project level so it's easier to discover compilation issues when considering a deployment target bump. IMHO: This also makes it easier to maintain, as the project's targets simply inherit their deployment target from a single version of truth.
|
Ready for review. cc: @ccgus, @robertmryan |
|
Thanks for doing this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As of today, the latest FMDB release available through the CocoaPods CDN specs repo is version
2.7.5. The reason why version2.7.7is not available is because the FMDB podspec fails the CocoaPods [required] lint step (ref: #793). This can impact the visibility and contribution to future FMDB releases in the context of developers who rely solely on public releases provided by the CocoaPods CDN specs repo.Purpose
The purpose of these changes is to sync up the iOS, Mac OS X, and Watch OS platform deployment targets within both the Xcode project file and CocoaPods podspec, so that subsequent FMDB releases (starting with version
2.7.8) can be made available through the CocoaPods CDN specs repo.Attachments
Related