Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCNN realization doesn't take exogenous variables as arguments #9

Closed
MBelniak opened this issue Jun 6, 2022 · 2 comments
Closed

FCNN realization doesn't take exogenous variables as arguments #9

MBelniak opened this issue Jun 6, 2022 · 2 comments

Comments

@MBelniak
Copy link

MBelniak commented Jun 6, 2022

Hi,

In the paper in eq. (1) it is stated, that FCNN in each block is a function of output of previous block/stack (y^{back}) + exogenous variables. Whereas, I see at https://github.com/cchallu/nbeatsx/blob/main/src/nbeats/nbeats_model.py#L122 that there's only y^{back} passed to FCNN. My question is: why is that? My reasoning for passing insample exog. variables as well is that they could provide additional information on how to scale the C_{s,l} context vector later on.

@kdgutier
Copy link
Collaborator

kdgutier commented Jun 6, 2022

Hi @MBelniak,

Thanks for the comment. For the moment scaling is done independently from the model.
By the transform_data and the Scaler Class.

We agree that insample exogenous variables could benefit by simplifying the neural forecasting pipeline, to help scale the features. That is still an open research question.

@MBelniak
Copy link
Author

MBelniak commented Jun 6, 2022

Thanks. I didn't exactly mean "scaling the features", but producing thetas, which in fact "scale" the C_{s,l,i} vector, but as I understand it's just an open question.

@MBelniak MBelniak closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants