Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-36 - Organize Environment and Logger init #46

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

GitHNX
Copy link
Collaborator

@GitHNX GitHNX commented May 13, 2024

  • Organizing Environment Variables
    • Affected Commands:
      • Dars Rec
      • Discord Bot
      • Monolith

- Organizing Environment Variables
@GitHNX GitHNX added the enhancement New feature or request label May 13, 2024
@GitHNX GitHNX requested a review from serafdev May 13, 2024 00:46
Copy link
Member

@serafdev serafdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ 🎖️ v

)

func init() {
environment.LoadEnvironmentVariables()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So beautiful

@serafdev
Copy link
Member

J'aime le title de la PR, maybe on devrait mettre une convention dans le pr.yml qui va vérifier what's up (e.g que le title est du format ISSUE-[0-9]*: .*)

@GitHNX
Copy link
Collaborator Author

GitHNX commented May 13, 2024

J'aime le title de la PR, maybe on devrait mettre une convention dans le pr.yml qui va vérifier what's up (e.g que le title est du format ISSUE-[0-9]*: .*)

jai create un issue

@GitHNX GitHNX merged commit 21ca548 into master May 13, 2024
@GitHNX GitHNX deleted the feature/ISSUE-36 branch May 13, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants