Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data types everywhere #20

Merged
merged 9 commits into from Mar 2, 2022
Merged

Add data types everywhere #20

merged 9 commits into from Mar 2, 2022

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Feb 17, 2022

Copy link
Member

@faxm0dem faxm0dem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,7 +1,7 @@
#
define syslog_ng::config (
$content = '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick search in our data and I didn't find any resource with empty content.
But agreed : it doesn't make sense to have an empty one.

@faxm0dem faxm0dem merged commit f2085b2 into master Mar 2, 2022
@smortex smortex deleted the data-types branch March 2, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants