Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subler (add Crossplatform support) #9

Closed
wants to merge 7 commits into from

Conversation

jvanbruegge
Copy link

I removed subler from the tagging fuctions so the code works with non-Mac machines. I tested the whole stuff on Linux and it worked flawless with iTunes.
The subler file is still there to support the optimize flag.
The library that is used is completely written in Python so it should work on all platforms.

@ccjensen
Copy link
Owner

Hey,

Thanks for the pull request. I invoked PlexMediaTagger with the exact same invocation with current master and then once again with your tool on a copy of the same video file. Seeing quite a few difference in what tags got added and their values:
screen shot 2015-07-22 at 20 20 38
was this intentional?

and I also saw an '8' get logged:

   processing 1/1 part_items
   tagging...
   8
   Finding '/Volumes/Drobo/TV/Psych/Psych - Season 8/Psych - S08E01 - Lock, Stock, Some Smoking Barrels and Burton Guster's Goblet of Fire.m4v' in iTunes...

any ideas on what that could be?

@jvanbruegge
Copy link
Author

oh, yeah, I didn't used all tags (like disk number, etc) I'll add them
The 8 could be a leftover from my debugging, will fix that too

@ccjensen
Copy link
Owner

cool, thanks!
I'm very interested in this change, and if it can match the capabilities of the current code I'd be more than happy to merge it in!

I'm going to be out of the country for the next few weeks, so take your time getting the final touches on this and I'll review it when I get back.

@ccjensen
Copy link
Owner

still interested in this if you'd like to get it cleaned up and ready to be merged!

@jvanbruegge
Copy link
Author

Yeah, will do this in the next few days

@ccjensen
Copy link
Owner

just noticed this was sitting here idle. Is this something that you are still pursuing?

@jvanbruegge
Copy link
Author

Not really, I am not using plex any more and the code here is horrible, from where I was just starting out with programming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants