Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snappy decompression performance #15

Open
markbaumgarten opened this issue Jan 4, 2023 · 3 comments
Open

Snappy decompression performance #15

markbaumgarten opened this issue Jan 4, 2023 · 3 comments

Comments

@markbaumgarten
Copy link

Ran a few tests and found that the snappy decompress function is a bit of a bottleneck.

Using python-snappy instead helped me a lot:

....
import snappy
...

def decompress(data: typing.BinaryIO) -> bytes:
    return snappy.uncompress(data.read())
@cclgroupltd
Copy link
Owner

Hi there, thanks for that. I think last time I checked that module required the snappy C library installed (and was a pain to use on Windows). Do you know if that's still the case?

@markbaumgarten
Copy link
Author

markbaumgarten commented Jan 14, 2023 via email

@cclgroupltd
Copy link
Owner

Yeah, I've had a look and it's still not exactly easy to install on Windows and requires an external dependency. So I might look at adding a "try import" around the C bindings and fall back to the pure Python version if that fails so we don't end up locking users out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants