Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orca steom #166

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Orca steom #166

merged 2 commits into from
Mar 3, 2024

Conversation

oliver-s-lee
Copy link
Contributor

Added a regression file for unusual orbital singly excited contributions with forms like:
-0.103557 42 -> x 42 -> 102

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Once the conflict is fixed, is the ORCA file good to go in?
  2. Can you separate out this other Gaussian output and also give the file a more descriptive name?

@oliver-s-lee
Copy link
Contributor Author

I'll be honest I know longer recall which PR this was for (:
Can't hurt to add in tho

@berquist
Copy link
Member

berquist commented Mar 2, 2024

Is this what you expect?

Attempting to read ORCA/ORCA5.0/steom_orbs.log
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Attribute etenergies changed value ([33836.9, 36610.5] -> [58430.9, 68624.7, 76876.5, 74256.2, 75911.9, 79565.9, 76654.9, 98867.4, 445807.6])
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Attribute etenergies changed value ([58430.9, 68624.7, 76876.5, 74256.2, 75911.9, 79565.9, 76654.9, 98867.4, 445807.6] -> [-3863.3, 5105.2, 6175.2,
 8684.6, 13523.6, 15104.0, 17891.2, 51559.7])
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Attribute etsyms changed value (['Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet'] -> ['Singlet',
'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet'])
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Warning:: the state may have not converged with respect to active space

[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Warning:: the state may have not converged with respect to active space

[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Attribute etenergies changed value ([-3863.3, 5105.2, 6175.2, 8684.6, 13523.6, 15104.0, 17891.2, 51559.7] -> [22054.5, 23776.0])
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Attribute etsyms changed value (['Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet', 'Singlet'] -> ['Triplet', 'Triplet'])
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Overwriting previous multipole moments with new values
[ORCA ORCA/ORCA5.0/steom_orbs.log WARNING] Attribute moments changed value ([array([-8.4234e-02,  1.0000e-06, -1.0000e-06]), array([ 5.71618393e+00,  5.08349246e-05, -0.00000000e+00])] -> [a
rray([-8.4234e-02,  1.0000e-06, -1.0000e-06]), array([4.58032838, 0.00922654, 0.01779222])])
cclib can parse the following attributes from ORCA/ORCA5.0/steom_orbs.log:
  atomcharges
  atomcoords
  atommasses
  atomnos
  ccenergies
  charge
  coreelectrons
  etenergies
  etsecs
  etsyms
  homos
  metadata
  moenergies
  moments
  mosyms
  mult
  natom
  nbasis
  nmo
  scfenergies
  scftargets
  scfvalues

@oliver-s-lee
Copy link
Contributor Author

In a nutshell, yes. Before the PR that fixed this the log file would have thrown an exception about casting str to int or whatever python says.

The warnings are a separate issue I think. For STEOM, we parse each of the excited state calcs in turn and replace any old data with the next (which will be a higher level of theory) until we get to the final STEOM energies. Works fine, but leads to lots of 'Attribute changed' warnings as we discard old data. Perhaps worth fixing with check_change of set_attribute?

@berquist
Copy link
Member

berquist commented Mar 3, 2024

I forgot about check_change. Yes, and I feel like we could use some logging for what is actually being parsed...for example, for the longest time in ORCA when reading a CCSD(T) calculation you'd only get the CCSD result since (T) wasn't parsed. If you saw at INFO or DEBUG level "parsed CCSD", "parsed CCSD(T)", "parsed EOM-CCSD" etc. maybe it would be useful.

@berquist berquist merged commit 4bbe982 into cclib:master Mar 3, 2024
1 check passed
@oliver-s-lee
Copy link
Contributor Author

@berquist yeah me too, I just had a feeling that these warnings could be hidden somehow.

Section logging is an interesting idea, although for the specific problem you describe this should definitely also be covered in metadata somehow. Maybe this sort of logging would be a good fit for the changes in V2? Speaking of, is there a breakdown of the plan moving forward somewhere? I see there's some cool stuff planned in eg cclib/cclib#1325 but not sure of the long-term direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants