Additional parsers #1302
Merged
Additional parsers #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Questions:
|
Let's do this once on
This needs to be a topic of discussion on tuesday |
shivupa
approved these changes
Nov 28, 2023
berquist
reviewed
Dec 4, 2023
berquist
approved these changes
Dec 4, 2023
| @@ -351,3 +351,56 @@ def finish(self): | |||
|
|
|||
| self.file_pointer = len(self.files) -1 | |||
| self.pos = self.size | |||
|
|
|||
| def skip_lines(self, sequence: typing.Iterable[str],virtual=False) -> typing.List[str]: | |||
|
Formatting will be done after the rebase. Tests I'm still not sure how this will work with the new pytest stuff which I increasingly think should be merged into |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the skip_line functionality from logfileparser as a class function into file_handler. This function might only ever be used in a virtual way, so the extra argument I've added might not be needed, but I wanted to be safe.
This is adding atomnos and atomcoords.