Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compactify if-else logic in main loop #424

Merged
merged 2 commits into from Mar 10, 2023
Merged

Compactify if-else logic in main loop #424

merged 2 commits into from Mar 10, 2023

Conversation

drewyoungren
Copy link
Collaborator

Makes loop logic tighter and makes the props for each 3DObject component uniform.

@nikolas nikolas self-assigned this Mar 10, 2023
@nikolas
Copy link
Member

nikolas commented Mar 10, 2023

Nice refactor. I wasn't familiar with <svelte:component this

@nikolas nikolas merged commit 0820d4f into main Mar 10, 2023
@nikolas nikolas deleted the tighten-main-loop branch March 10, 2023 14:05
@drewyoungren drewyoungren mentioned this pull request Mar 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolas nikolas nikolas left review comments

Assignees

@nikolas nikolas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewyoungren @nikolas