Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow panel to be scrolled again #587

Merged
merged 1 commit into from
May 18, 2023
Merged

Allow panel to be scrolled again #587

merged 1 commit into from
May 18, 2023

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented May 18, 2023

This is a quick fix for a major bug: the object list is currently not scrollable.

Closes #586

Re-introduce overflow-y: auto so panel can be scrolled when there are many objects.

Also, this bug highlighted an issue with my new ResizeObserver setup - this observer needs to be disabled when the pointermove event is updating the width.

@nikolas nikolas marked this pull request as draft May 18, 2023 19:44
@Evan-CTL
Copy link
Collaborator

When there is overflow and the scrollbar appears the drag button constantly fights to return the panel to its default size. Making it basically unusable when the object list overflows past the browser window.

Side Note: Should the drag button be hidden when the menu is collapsed/hidden?

@nikolas nikolas force-pushed the panel-scroll-fix branch 2 times, most recently from aceba34 to 90b755a Compare May 18, 2023 19:53
@nikolas nikolas marked this pull request as ready for review May 18, 2023 19:53
@nikolas
Copy link
Member Author

nikolas commented May 18, 2023

Okay, it turns out the ResizeObserver I introduced was completely unnecessary, and just causing problems. I'm not sure why I thought I needed this in the first place, looking back.

Anyways, try one more time on this updated branch. The resizer now appears to be working properly when the scroll bar is present.

@nikolas
Copy link
Member Author

nikolas commented May 18, 2023

And yeah, the drag button doesn't do anything when the panel is hidden, so we can just remove it or otherwise disable it when it's in that state. I'll make those changes on a separate PR, as there's some subtlety around when to hide it, to make it not look glitchy.

This is a quick fix for a major bug: the object list is currently not
scrollable.

Closes #586

Re-introduce `overflow-y: auto` so panel can be scrolled when there are
many objects.
@Evan-CTL Evan-CTL merged commit 63d80e7 into main May 18, 2023
@Evan-CTL Evan-CTL deleted the panel-scroll-fix branch May 18, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel isn't scrollable
2 participants