Search input changes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made a few changes here: * Capture the form.submit event, to prevent the Return key in the search field from triggering a traditional form submit. * use type="search" on the search input field * ran whitespace-cleanup-region on the css file and auto-formatted it. the formatting was all messed up.
nikolas
commented
Apr 17, 2017
| @@ -258,6 +258,9 @@ | |||
| }); | |||
|
|
|||
| $('#clear-search').click(clearSearch); | |||
| $('form.search-container').submit(function(e) { | |||
There was a problem hiding this comment.
An alternative to capturing the submit event here and ignoring it could be to just change the form element to a div element, since we're not using the traditional form behavior anyways. That might even be a cleaner approach... but it's no big deal either way.
There was a problem hiding this comment.
My vote would be to leave it as a form element so its picked up in any form styles that Marc may lay down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few changes here:
field from triggering a traditional form submit.
the formatting was all messed up.