Fix bug where cached value wasn't used when value was 0 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging the `is_last_child` cache, I saw the value of cache.get() here is either 1, 0, or None if the cached value isn't present. Currently, only values of 1 are getting used, because if the value is 0, the `if v:` to check if the cache is present fails. I think we need to be more specific here and do: `if v is not None:` This change improved performance a little bit in my local testing with memcached, but it's still not great: Calling the cache for each node in the tree takes time, and it would be great to find a way to interact with the cache just once for the pagetree edit page. refs #63
thraxil
added a commit
that referenced
this pull request
May 4, 2015
Fix bug where cached value wasn't used when value was 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging the
is_last_childcache, I saw the valueof cache.get() here is either 1, 0, or None if the cached
value isn't present. Currently, only values of 1 are getting
used, because if the value is 0, the
if v:to check ifthe cache is present fails. I think we need to be more
specific here and do:
if v is not None:This change improved performance a little bit in my local testing
with memcached, but it's still not great: Calling the cache for
each node in the tree takes time, and it would be great to find
a way to interact with the cache just once for the pagetree edit
page.
refs #63