Adjust jsxgraph board settings #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nikolas
commented
Aug 18, 2023
•
nikolas
commented
- Reduce bounding box closer to the axes, so the invalid domains are not visible. This is a roundabout way to resolve issue Restrict graph lines to positive values #2673, as it seems there is no general way to add this restriction to jsxgraph's Line element, according to the thread referenced in that issue.
- Use Label's autoPosition option for the demand-supply graph's line labels. This option is new in jsxgraph 1.1.0, and will give us some better dynamic position for the line labels, through my testing. The auto-positioning isn't ideal (see: Label.autoPosition should take the board's boundingBox into account jsxgraph/jsxgraph#575), but it looks like it's an improvement.
* Reduce bounding box closer to the axes, so the invalid domains are not visible. This is a roundabout way to resolve issues #2673, as it seems there is no general way to add this restriction to jsxgraph's Line element, according to the thread referenced in that issue. * Use Label's [autoPosition](https://jsxgraph.uni-bayreuth.de/docs/symbols/Label.html#autoPosition) option for the demand-supply graph's line labels. This option is new in jsxgraph 1.1.0, and will give us some better dynamic position for the line labels, through my testing. The auto-positioning isn't ideal (see: jsxgraph/jsxgraph#575), but it looks like it's an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.