react-grid-layout fixes #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, the react-grid-layout update actually did cause some bugs that I didn't catch. Moving the track items wasn't updating the state. I've fixed this up here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the react-grid-layout update actually did cause some bugs that I
didn't catch. I've fixed this up here.
The first problem was that moving the track items wasn't updating the state. That was a simple fix due to the rgl update.
The second problem: updating the state wasn't actually reflected in the layout of the track elements. Using the TimecodeEditor to update the start time, for example, wouldn't move the track element.
I had forgotten that I fixed this problem with a small change here: react-grid-layout/react-grid-layout#382 (comment)
I'd really like to get off of using our fork of this though - it causes problems. After reading the rest of the thread, it looked like I can fix this by specifying the layout to the surrounding ReactGridLayout element as well as on the individual items: react-grid-layout/react-grid-layout#382 (comment)
I've done this here, with the generateLayout method. I've duplicated some code here, but it's still an improvement since this allows us to use the standard version of react-grid-layout.