Skip to content

Commit

Permalink
Merge pull request securego#162 from gcmurphy/bugfix
Browse files Browse the repository at this point in the history
Cleanup vet failures and unused files
  • Loading branch information
gcmurphy committed Jan 29, 2018
2 parents 07a2eec + a97a196 commit 8125622
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 32 deletions.
4 changes: 1 addition & 3 deletions analyzer_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package gas_test

import (
"bytes"
"io/ioutil"
"log"
"os"
Expand All @@ -20,10 +19,9 @@ var _ = Describe("Analyzer", func() {
var (
analyzer *gas.Analyzer
logger *log.Logger
output *bytes.Buffer
)
BeforeEach(func() {
logger, output = testutils.NewLogger()
logger, _ = testutils.NewLogger()
analyzer = gas.NewAnalyzer(nil, logger)
})

Expand Down
25 changes: 0 additions & 25 deletions glide.lock

This file was deleted.

3 changes: 2 additions & 1 deletion import_tracker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package gas_test

import (
. "github.com/onsi/ginkgo"
//. "github.com/onsi/gomega"
. "github.com/onsi/gomega"
)

var _ = Describe("ImportTracker", func() {
Expand All @@ -15,6 +15,7 @@ var _ = Describe("ImportTracker", func() {
})
Context("when I have a valid go package", func() {
It("should record all import specs", func() {
Expect(source).To(Equal(source))
Skip("Not implemented")
})

Expand Down
4 changes: 1 addition & 3 deletions rules/rules_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package rules_test

import (
"bytes"
"fmt"
"log"

Expand All @@ -17,14 +16,13 @@ var _ = Describe("gas rules", func() {

var (
logger *log.Logger
output *bytes.Buffer
config gas.Config
analyzer *gas.Analyzer
runner func(string, []testutils.CodeSample)
)

BeforeEach(func() {
logger, output = testutils.NewLogger()
logger, _ = testutils.NewLogger()
config = gas.NewConfig()
analyzer = gas.NewAnalyzer(config, logger)
runner = func(rule string, samples []testutils.CodeSample) {
Expand Down

0 comments on commit 8125622

Please sign in to comment.