:crypto.hmac has been deprecated and removed in OTP 24 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerichsen
changed the title
|
Please note that the latest plug_crypto (1.2.0) does not have the fix mentioned. It has not been released to hex yet. So in order to have plug_rails_cookie_session_store work in OTP 24, the code from this PR as well as an updated version of plug_crypto has to be used. |
|
OK, plug_crypto 1.2.1 with OTP 24 compatibility has been released :-) |
|
Thanks @joerichsen . The project needs some love, and I just didn't have the time. |
|
No worries, that's life :-) Thank you for merging my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies the same fix as in https://github.com/elixir-plug/plug_crypto/blob/8c1f9271c9a0fb241b1cc970608187246d88d29d/lib/plug/crypto/key_generator.ex\#L95