/characters/{character_id}/assets/ returns implants/skills/wardrobe items for some characters

[wvdvegt]

Bug

the v1 endpoint:

/characters/{character_id}/assets/

returns implants/skills and/or wardrobe items for some characters as part of the inventory.
This without specifying that implants can be queried (so no scope for it).

The character returned by this as a container (but not for all pilots and not with all item types). So I have 3 pilots with skills+implants+wardrobe) , one with only implants an and one that does not have his character returned as a asset container.

Request

I used:
/characters/{character_id}/assets/
esi-assets.read_assets.v1

I read all pages until less than a 1000 where returned.

Response

For some characters not only assets in stations are returned, but also the character itself containing items like implants, learned skills and/or wardrobe items.

Status Code

200

Headers

Body

One item returned is:

  {
    "is_singleton" : true,
    "item_id" : 165495902,
    "location_flag" : "Skill",
    "location_id" : 148948054,
    "location_type" : "other",
    "quantity" : 1,
    "type_id" : 3303
  }

Expected

As there are other endpoints covering these (at least the skills/implants) I would expect them not to be present in this endpoint (especially as implants requires a separate scope not present in my app).

200

Checklist

Check all boxes that apply to this issue:

• Bug description is provided
• Request path is provided
• Response status code is provided
• Response headers are provided
• Response body is provided
• Expected response is provided

[a-tal]

thanks for this. the only items you should see now where location_id == character_id are wardrobe items, because there's no other route for retrieving that information.

[CarbonAlabel]

@a-tal what about those who can't see our clothes in the assets list?

[a-tal]

@CarbonAlabel I'd have to look into why it's only returned sometimes. it wouldn't surprise me if "characters who haven't changed clothes for a long time" played into it somehow though.

feel free to make a separate issue for that, will require some monolith investigation

[GoldenGnu]

I don't know if you already excluded them, but, at one point, active boosters was also returned.
Maybe you already excluded them, in that case, sorry to waste time...

[wvdvegt]

I do not see any characters anymore, even the one that had the wardrobe item.