existingSecret for users and configurable accessMode for Samba

[mosanden]

What this PR does / why we need it:

• Enable usage of existingSecret for Samba users: It is now possible to define users separate from the chart, e.g. in a SealedSecret.

• Make accessMode for volumes configurable in Samba: For example hostPath PVs do not support ReadWriteMany.

Checklist

• Chart Version bumped
• make docs lint passes
• Variables are documented in the values.yaml as required in Helm-Docs.
• PR contains the label that identifies the chart, e.g. chart/[chart]
• PR contains the label that identifies the type of change, which is one of
  bug, enhancement, documentation, change, breaking, dependency

[mosanden]

Hey there, this PR needs the labels change and chart/samba i guess but I don't understand how I can add them.

[ccremer]

Hi!
Thanks for the interest and PR!
The change overall looks good to me :)

In CI the linting is failing, looks like you forgot a small change. However, the unit test job might need some investigation. It's been a while since I worked on the charts, so we might skip that one, unless you find the error immediately :)

[mosanden]

Seems like I didn't generate the docs correctly.

For the tests I get this for a local make test:

$ make test
--- Executing unit tests
ok      github.com/ccremer/charts/charts/emby/test      (cached)
ok      github.com/ccremer/charts/charts/fronius-exporter/test  (cached)
ok      github.com/ccremer/charts/charts/znapzend/test  (cached)

[ccremer]

I propose a slight change in the parameter, allowing more flexibility. Otherwise LGTM

[mosanden]

I like that idea. I'll check if it works.

[mosanden]

Seems to work!

[ccremer]

Perfect!
Thank you for your contribution and time :)

[mosanden]

Thank you!