Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename predicate.WrapIn() to If() #22

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Rename predicate.WrapIn() to If() #22

merged 1 commit into from
Dec 20, 2021

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented Dec 20, 2021

Summary

  • Renames predicate.WrapIn() to predicate.If()
  • Changes signature of predicate.If(...) so that the parameters are interchanged.

This change makes it easier to read a nested pipeline like

predicate.If(authenticated(), pipeline.NewStepFromFunc("query db", ...))

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    fix, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update documentation.
  • Update tests.
  • Link this PR to related issues.

@ccremer ccremer merged commit 782ba46 into master Dec 20, 2021
@ccremer ccremer deleted the predicate-if branch December 20, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant