Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipeline cancellation with Go's native Context #29

Merged
merged 5 commits into from
Feb 27, 2022
Merged

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented Feb 18, 2022

Summary

  • Replaces the pipeline.Context type with context.Context throughout the code. To pass data around, use context.WithValue instead
  • Pipelines can now be canceled. In case of cancellation, now steps are scheduled for execution, however each step has to listen for the cancellation event themselves.
  • Support canceling parallel.NewFanoutStep with changed PipelineSupplier usage. See the example in godoc on how to properly configure this.
  • Support canceling parallel.NewWorkerPoolStep with changed PipelineSupplier usage. See the example in godoc on how to properly configure this.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    fix, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update documentation.
  • Update tests.

@ccremer ccremer merged commit 36dadc2 into master Feb 27, 2022
@ccremer ccremer deleted the context branch February 27, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant