Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'abort' feature #49

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Remove 'abort' feature #49

merged 1 commit into from
Jul 28, 2022

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented Jul 28, 2022

Summary

It never felt quite right to have it in this lib (and in practice I never had a use case).
Users can perfectly return their own kind of errors and check for those with errors.Is().

The Result now has removed the following funcs:

  • IsCompleted() -> Without the abort feature it's equivalent to ÌsSuccessful(), use this instead
  • IsAborted() -> removed, return your own error type and check for this using errors.Is()

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    fix, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update documentation.
  • Update tests.

It never felt quite right to have it in this lib.
Users can perfectly return their own kind of errors and check for those with errors.Is().
@ccremer ccremer merged commit 44933e5 into master Jul 28, 2022
@ccremer ccremer deleted the remove-abort branch July 28, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant