MustLoadFromContext now panics if the key is not present #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually conforms to the usual "must" convention. Besides, returning nil if a key is not found only hides the root cause when troubleshooting nil pointer panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This actually conforms to the usual "must" convention.
Besides, returning nil if a key is not found only hides the root cause when troubleshooting
nil pointer panics.
Users that depend on previous behaviour (returning nil or default value) can now use new function
LoadFromContextOrDefaultand pass a default value that is returned in case of inexisting key.Checklist
fix,enhancement,documentation,change,breaking,dependencyas they show up in the changelog