Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why test is disabled #11

Closed
Anthchirp opened this issue Jan 6, 2017 · 0 comments
Closed

Investigate why test is disabled #11

Anthchirp opened this issue Jan 6, 2017 · 0 comments
Assignees
@graeme-winter
Labels
dxtbx

Comments

@Anthchirp
Copy link
Member

Just came across https://github.com/cctbx/cctbx_project/blob/master/dxtbx/tests/tst_dials_226.py#L24, apparently related to dials/dials#226
Test is disabled, but prints 'OK', so is treated as success.

@graeme-winter could you have a look and check whether this test can be re-enabled, removed or should remain disabled. If the latter please change print to "Skip" instead of "OK" - this causes Jenkins to display the test as skipped instead of passed.
Anthchirp added a commit that referenced this issue Sep 26, 2017
@Anthchirp
make test skipping work. test still disabled though, #11
1e223ed
pcxod pushed a commit to pcxod/cctbx_project that referenced this issue Mar 7, 2019
@pascal22p
Merge pull request cctbx#11 from pascal22p/chiv_plane_restraint
ee317ca 
Chiv plane restraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graeme-winter graeme-winter

Labels
dxtbx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graeme-winter @Anthchirp