Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple dxtbx compile time dependencies: cbflib #125

Closed
2 tasks
phyy-nx opened this issue Jan 25, 2018 · 1 comment
Closed
2 tasks

Decouple dxtbx compile time dependencies: cbflib #125

phyy-nx opened this issue Jan 25, 2018 · 1 comment

Comments

@phyy-nx
Copy link
Contributor

phyy-nx commented Jan 25, 2018

Allow dxtbx to be compiled in an environment without cbflib. Two work items:

  • Isolate includes of cbf.h and other cbflib header files to a separate boost python extension model
  • Make the dxtbx SConscript skip compiling this extension module if cbf.h is not present
phyy-nx added a commit that referenced this issue Feb 7, 2018
@phyy-nx
Make iotbx depend on dxtbx, but only if dxtbx is explicitly configured.
0340a7e 
Makes use of the keyword optional_modules_only_if_explicit_request keyword, added by @luc-j-bourhis.

See #125 and #126.
mlxd pushed a commit to ExaFEL/cctbx_project that referenced this issue Feb 16, 2018
@phyy-nx @mlxd
Make iotbx depend on dxtbx, but only if dxtbx is explicitly configured.
c1f1902 
Makes use of the keyword optional_modules_only_if_explicit_request keyword, added by @luc-j-bourhis.

See cctbx#125 and cctbx#126.
@phyy-nx
Copy link
Contributor Author

phyy-nx commented Feb 20, 2018

Closing this, as 0340a7e and the new cctbxlite builder allows users to build cctbx without cbflib or dxtbx.

@phyy-nx phyy-nx closed this as completed Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phyy-nx