-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conda environments (Python 3.7 and 3.8) #409
Conversation
d2034e0
to
588c797
Compare
e6386f0
to
03c96ad
Compare
9828ba1
to
5436f05
Compare
018c86f
to
b0abfed
Compare
dabbf68
to
af6955e
Compare
2b01568
to
9d0b61c
Compare
Hi @bkpoon I just build this branch on my Windows10 workstation using VS2015 with the commandline
One detail that confused me was how to achieve a successful build of this branch. I ended up using the above command line and hitting the pause button on the keyboard as soon as the download of cctbx_project had completed so that I could manually switch branch from master to newpy. Then hit the return key to resume the boostrap build. |
@Oeffner I don't normally download a completely new set of repositories. For this branch, since it changes dependencies, I'll make a symbolic link to an existing
|
Hi @bkpoon , @luc-j-bourhis. I do not use conda for building cctbx for Olex2 - I rely on the old fashioned way that seems to have been working for a while bow. After getting the bundle (which is apparently missing on this page https://cctbx.github.io/installation.html#id3, but as I remember last time I got it with bootstrap), I typically use 'configure iotbx smtbx fast_linalg' and have to leave with the dependencies that come along them. But these are as close as a minimal set. |
In porting python modules in our phaser repo to python3 I have encountered problems with the scitbx.suffixtree module. The regression test, cctbx_project\scitbx\suffixtree\test\tst_single.py, fails in a python3 build with lots of errors like |
@Oeffner It's been failing on Windows, but shows up as a warning because of the stderr output. I looked briefly into it a while ago, but wasn't able find a fix. Also, the test is marked as an expected failure for newer versions of GCC. There is a segmentation fault. @gbunkoczi would know more about that code. |
- Optimization changes lbfgs behavior in scitbx/lbfgs/tst_lbfgs_fem.py - With the flag, minimization may take more steps than the fortran reference
- Add Python 3.7 and 3.8 environments - Add environments for cctbxlite - Bulk update to latest versions
- Check self.use_conda against None - scons is available as conda packages
- Use headers from https://github.com/chemeris/msinttypes - Use commit 7636cabe55318824dc702d15b69711f5d7c30250, not the latest
- Stop Xcode 10.2.1 builds - Add FLAGS parameter - Set PYTHONLEGACYWINDOWSSTDIO for Windows tests
- New Windows console in Python 3.6 and greater does not work with os.dup2 - https://bugs.python.org/issue30555 - https://stackoverflow.com/questions/52373180/python-on-windows-handle-invalid-when-redirecting-stdout-writing-to-file
- This flags allows selection of a specific version of Python - Just passes the argument to the --python flag of libtbx.install_conda.
- Removes the command-line flags for python3 and wxpython4 - Options still remain and python3 will be enabled for install_base_packages.py by using the --python flag with "36", "37", or "38" as arugments - wxpython4 will be enabled by python3 or macOS >= 10.14
- Removes -ffast-math and tests -O0, -O1, -O2, and -O3 for linux and macOS - Removes /fp:fast and tests /O1 and /O2 for Windows - Add "MODULES" variable and "modules" parameter to select modules artifact name - Change ubuntu-16.04 to ubuntu-latest [skip ci]
I raised a question in our group meeting today: The next DIALS release is coming up in May. For planning purposes only - do you have a date in mind when you plan to merge this? |
@Anthchirp How about next Friday, May 8th at 3 pm Pacific? I'll make the changes to just use the I made the changes to remove the @pcxod @luc-j-bourhis I'll try to construct a minimal set of dependencies for the iotbx, smtbx, and fast_linalg modules. It may just be |
The suggested timestamp works well and leaves us plenty of time to iron out any potential issues before the release. Thank you! |
Test updated dependencies and add Python 3.7 (and maybe 3.8) support
List of changes
cctbxlite
environments (not yet enabled)pyside2
,pyzmq
andwebsocket-server
for @Oeffner tocctbx
environmentsconda
environments for linux, macOS, and Windows for Python 2.7, 3.6, 3.7, and 3.8a) Windows
b) CentOS 6
c) macOS 10.14 (Xcode 11.3.1)
a) Windows
b) CentOS 6, 7, 8
c) Ubuntu 14.04, 16.04, 18.04 (will replace 14.04 with 20.04 when it's released later in April)
d) macOS 10.14 Xcode 11.3.1 and 10.3, and macOS 10.15 Xcode 11.4
a) Match current version for
conda
b) Enables Python 3.7 and later support
c) Enables support for latest versions of CUDA
a) Match version for
conda
packages--python
flag tobootstrap.py
for selecting Python versiona) Just passes argument to
libtbx.install_conda
scons
moved intoconda
environment--no-boost-src
flag tobootstrap.py
to prevent downloading of Boost into modules during theupdate
step.-ffast-math
(/fp:fast
for Windows) is removed and-O0
,-O1
,-O2
, and-O3
(/O1
and/O2
for Windows) are tested on the Full build (160 builds).@Oeffner Can you double check the Windows builds are working for you?
@luc-j-bourhis @pcxod @Oeffner Are there any changes that you would like to the
cctbxlite
environments? Currently, these are the dependencies incctbxlite
We can probably cut down the number of dependencies for
cctbxlite
.